Make it possible to use multiple tokens. #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is based on the work of @valentinschabschneider and updated to the latest master branch. deckweiss@9653c35#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80 Fixes piceaTech#104.
|
This looks good to me and very useful if one is migrating a repository which is in use and has multiple collaborators. @spruce |
spruce
requested changes
Dec 28, 2023
| settings.github.token_owner) || | ||
| author.username === settings.github.token_owner) | ||
| this.githubApis[settings.usermap[author.username as string]]) || | ||
| // settings.usermap[author.username as string] === |
There was a problem hiding this comment.
Can you remove the comments. So we don't clutter the codebase
| settings.github.token_owner) || | ||
| note.author.username === settings.github.token_owner; | ||
| let userIsPoster = this.userTokenAvailable(note.author); | ||
| // (settings.usermap && |
| @@ -917,7 +929,8 @@ export class GithubHelper { | |||
| let bodyConverted = await this.convertIssuesAndComments( | |||
| mergeStr + mergeRequest.description, | |||
| mergeRequest, | |||
| !this.userIsCreator(mergeRequest.author) || !settings.useIssueImportAPI | |||
| !this.userTokenAvailable(mergeRequest.author) // || | |||
| //!settings.useIssueImportAPI | |||
|
Thank you for the nice PR! We try to use this PR for migrating our Issues from GitLab to GitHub. Using multiple tokens to connect user accounts seems to work as expected without using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the work of @valentinschabschneider and updated to the latest master branch:
deckweiss@9653c35#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80
Fixes #104.