Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move nested sass declarations after non-nested declarations #596

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nstringham
Copy link

This PR fixes #577 by reordering some sass declarations to work with the new rules for mixed declarations. See https://sass-lang.com/documentation/breaking-changes/mixed-decls for more info.

@bunnymatic
Copy link

Sad at the number of files that needed touching but happy that you might have uncovered the issue and solved it.

@nstringham
Copy link
Author

If you want I can move color-scheme down so that this change only effects the SCSS not the CSS but it felt a bit cleaner to me like this.

@tirthbodawala
Copy link

This is a great PR to be honest, I was getting the same issue and was going to create the PR, but @nstringham already did it. Awesome! When do we get this?

@blachawk
Copy link

blachawk commented Sep 5, 2024

I'm currently using "@picocss/pico": "^2.0.6", within my npm workspace.

What version of picocss do we need to update to, to overcome these Deprecation Warnings?

@nstringham
Copy link
Author

What version of picocss do we need to update to, to overcome these Deprecation Warnings?

You need to wait until this PR is merged.

@bunnymatic
Copy link

If you want I can move color-scheme down so that this change only effects the SCSS not the CSS but it felt a bit cleaner to me like this.

just a super nit. I think it's great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warnings with Sass 1.77.8
4 participants