update REMIND input data after unit shift #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,7 +47,7 @@ toolEdgeTransportSA <- function(SSPscen, | |||
| ######################################################## | |||
| if (is.null(outputFolder) & isStored) stop("Please provide an outputfolder to store your results") | |||
| if (is.null(gdxPath)) {gdxPath <- file.path(getConfig("sourcefolder"), | |||
| "REMINDinputForTransportStandalone", "fulldata.gdx")} | |||
There was a problem hiding this comment.
does this mean, you substituted the old fulldata.gdx file? Should we keep it to be able to reproduce old input data? Why not renaming the file which is read in?
There was a problem hiding this comment.
I use the approach we agreed on for inputdata versioning:
- create version folders and move the files to each folder
- create a symlink in the root folder linking to the old file for backwards compatibility
Please take a look at the folders and files on the cluster.
There was a problem hiding this comment.
ah, it is a subfolder, fine!
LaviniaBaumstark
approved these changes
Sep 27, 2024
|
We could also include a readme with information about the REMIND run (maybe at least a path on the cluster). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.