Use pip requirements, add github actions #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SallyDa
force-pushed
the
main_actions
branch
2 times, most recently
from
2e0a376
to
76797a0
Compare
for more information, see https://pre-commit.ci
JakobBD
reviewed
Nov 12, 2024
| authors = ["Jakob Dürrwächter, Merlin Hosak, Stefan Pauliuk"] | ||
| authors = [ | ||
| {name = "Jakob Dürrwächter"}, | ||
| {name = "Merlin Hosak"}, |
There was a problem hiding this comment.
Suggested change
| {name = "Merlin Hosak"}, | |
| {name = "Sally Dacie"}, | |
| {name = "Merlin Hosak"}, |
There was a problem hiding this comment.
Do you want to add your email as well @JakobBD ? I didn't want to add it for you...
There was a problem hiding this comment.
I'm fine with just the name, thanks for asking! :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated formatting with black.
Automated running of tests with pytest (including installing dependencies with pip).
We can discuss whether we want to use black or something else, whether we want these formatting changes to be committed automatically (as done here), and whether we want to use pip or poetry for dependencies (didn't get the tests running automatically using the poetry environment, but could spend more time looking into this). We can also discuss if we want anything else automated, and if we want these checks/commits to apply to other branches than main.