Add authres_permitpartialpass option #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option will make any authres_status return FAIL if any authres result fails For cases where spf=pass and dkim=pass and dmarc=fail and you don't want to show partialsuccess (green icon)
|
@tomsommer Thanks for the PR. I might not fully understand your use case, but why is disabling Wdyt about a strict mode otherwise? Not sure what other things we could add under that but might be a bit more flexible? |
pimlie
reviewed
Apr 9, 2024
| @@ -472,6 +472,12 @@ public function get_authentication_status($headers, $show_statuses = 0, $uid = 0 | |||
| } | |||
| } | |||
|
|
|||
| // at least one auth method was passed, show partial pass | |||
| $rcmail = rcmail::get_instance(); | |||
| if (($status & self::STATUS_PASS) && ($status & self::STATUS_FAIL) && $rcmail->config->get('authres_permitpartialpass', true)) { | |||
There was a problem hiding this comment.
How can a user configure authres_permitpartialpass? I guess we also need a checkbox in preferences?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option will make any authres_status return FAIL if any authres result fails
For cases where spf=pass and dkim=pass and dmarc=fail and you don't want to show partialsuccess (green icon).
Change is backwards compatible.