Skip to content

Commit

Permalink
Revert "Update Node tests to Jasmine 5.1"
Browse files Browse the repository at this point in the history
Forgot to check Node.js support here. Jasmine 5.1 requires Node.js 18+. Even though we've decided we aren't worrying about requiring newer versions now, this seems a bit too big of a jump. Setting aside for now, but we can easily bring this back if we want.
  • Loading branch information
Mr0grog committed Jan 18, 2024
1 parent 160fc4c commit bb00d41
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
9 changes: 5 additions & 4 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,11 @@ module.exports = function (grunt) {
var done = this.async();

var jasmine = new Jasmine({ projectBaseDir: __dirname });
jasmine.exitOnCompletion = false;
jasmine.execute(this.options().specs)
.then(function(info) { done(info.overallStatus === 'passed'); })
.catch(function(error) { done(error); });
jasmine.onComplete(function(success) {
done(success);
});

jasmine.execute(this.options().specs);
});

// Build a distributable release
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"grunt-open": "~0.2.3",
"grunt-preprocess": "^5.1.0",
"grunt-template-jasmine-istanbul": "https://github.com/maenu/grunt-template-jasmine-istanbul.git#caedc636b9f9c11217a32d586717e3153edf9ba3",
"jasmine": "^5.1.0",
"jasmine": "^2.4.1",
"typescript": "^3.5.1"
},
"keywords": [
Expand Down

0 comments on commit bb00d41

Please sign in to comment.