Avoid unquoting quoted slashes in an href #1147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behavior would unquote any %-encoded characters in hrefs, including slashes, and then re-encode them, excluding slashes. This caused a fatal error when the href contained quoted slashes. The final href with the originally quoted slashes now unquoted, would not exist and prevent an entire calendar from syncing completely.
It looks to me like the unquote step is only there to avoid re-quoting already quoted characters. In order to avoid leaving quoted slashes unuoted, I have removed the unquote step and added the % symbol to the list of characters to leave unquoted when quoting the href.