Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presentation detail link proposal #106

Closed

Conversation

miurahr
Copy link
Contributor

@miurahr miurahr commented Jul 25, 2015

Implemented #91

@@ -147,6 +149,12 @@ def notification_email_context(self):
"kind": self.kind.name,
}

def save(self, *args, **kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about #110?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#110 is for a slot name. here is for a proposal with same way.

@paltman
Copy link
Member

paltman commented Aug 3, 2015

@jtauber was there a specific reason for the copying over of these fields? Could they ever change on one but not the other? If not, I think this is a decent change.

@miurahr
Copy link
Contributor Author

miurahr commented Aug 3, 2015

@jtauber I've tested this code on my project and it does not use review app.
I'm afraid whether review app and this modification work well or not.

@miurahr miurahr force-pushed the presentation_detail_link_proposal branch from 617b298 to cad6d1e Compare August 3, 2015 14:51
@miurahr
Copy link
Contributor Author

miurahr commented Aug 3, 2015

rebased.

@miurahr miurahr force-pushed the presentation_detail_link_proposal branch from cad6d1e to 8aa5abb Compare September 14, 2015 13:52
@miurahr
Copy link
Contributor Author

miurahr commented Oct 17, 2015

This PR make a bug to reverse-reference from Speaker to Presentation. Because it drop speaker field from Presentation and add a function to refer Proposal.speaker. This cause a problem.

@miurahr
Copy link
Contributor Author

miurahr commented Oct 17, 2015

I'd like to mark it Invalid and close.

@miurahr miurahr closed this Oct 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants