-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support download uploaded documents #532
Open
Rutheniumlmw
wants to merge
7
commits into
pingcap:main
Choose a base branch
from
Rutheniumlmw:lmw_466
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
00870b0
fix:The link of upload files is broken in the chat view (#466)
ee32c05
fix:The link of upload files is broken in the chat view (#466)
b6b3439
Merge remote-tracking branch 'origin/main' into lmw_466
60ea247
The link of upload files is broken in the chat view #466
634f951
fix:The link of upload files is broken in the chat view #466
Rutheniumlmw 621e4aa
fix:The link of upload files is broken in the chat view #466
Rutheniumlmw 5c553c9
fix:The link of upload files is broken in the chat view #466
Rutheniumlmw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
from fastapi import FastAPI, HTTPException, APIRouter | ||
from fastapi.responses import StreamingResponse | ||
from sqlmodel import Session | ||
from app.api.deps import SessionDep | ||
from app.repositories import document_repo | ||
from app.file_storage import get_file_storage | ||
|
||
router = APIRouter() | ||
|
||
@router.get("/documents/{doc_id}/download") | ||
def download_file( | ||
doc_id: int, | ||
session: SessionDep | ||
): | ||
doc = document_repo.must_get(session, doc_id) | ||
|
||
name = doc.source_uri | ||
filestorage = get_file_storage() | ||
if filestorage.exists(name): | ||
file_size = filestorage.size(name) | ||
headers = {"Content-Length": str(file_size)} | ||
def iterfile(): | ||
with filestorage.open(name) as f: | ||
while chunk := f.read(8192): # 每次读取 8KB | ||
yield chunk | ||
return StreamingResponse( | ||
iterfile(), | ||
media_type = doc.mime_type, | ||
headers = headers | ||
) | ||
else: | ||
raise HTTPException(status_code = 404, detail = "File not found") | ||
|
||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refer to FastAPI Document. It's not necessary to manually call
f.read()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done