-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maintainer, scheduler: support dynamic merge and split #698
Merged
CharlesCheung96
merged 24 commits into
pingcap:master
from
CharlesCheung96:add-more-comments
Dec 25, 2024
Merged
maintainer, scheduler: support dynamic merge and split #698
CharlesCheung96
merged 24 commits into
pingcap:master
from
CharlesCheung96:add-more-comments
Dec 25, 2024
+1,578
−489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlesCheung96
changed the title
Add more comments
maintainer, scheduler: support dynamic merge and split
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group Checker
GroupChecker
checks whether the scheduling state of all tasks in a group meets the specified constraints based on the task status.This PR implements two basic checker:
hotSpanChecker focuses on identifying and managing "hot spans", which are spans with high throughput.
rebalanceChecker focuses on rebalancing the load across nodes to ensure fairness. It evaluates global system conditions and decides whether to merge or rebalance spans based on load thresholds and imbalance ratios. The details are:
a. Node Constraint: trigger MergeAndSplit if
len(s.allTasks) < len(allNodes)*MinSpanNumberCoefficient
b. Hard Imbalance Constraint: trigger MergeAndSplit if
maxLoad-minLoad >= float64(s.hardWriteThreshold) && maxLoad/minLoad > s.hardImbalanceThreshold
c. Soft Imbalance Constraint: trigger MergeAndSplit if
softRebalanceScore
accumulates up tos.softRebalanceScoreThreshold
d. Soft merge Constraint: trigger Merge if
softMergeScore
accumulates up tos.softMergeScoreThreshold
Manuual Tests
Hot Span && Node Constraint
Rebalance Spans
Merge Spans
[TODO] Improve check strategies
There are several shortcomings in the current implementation, and possible improvements include:
enable-table-across-nodes
configuration enabled, it ensures that only sufficiently large tables are split.enable-table-across-nodes
disabled, the scheduler ensures basic load balancing across nodes.split granularity.