Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ps_engine.raftlog unset under default raft-engine dir #404

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Dec 16, 2024

What is changed and how it works?

Issue Number: Close #xxx

See tiflash#9727

The previous PR #367 does not totally fixed the issue.

Infer the dir of raft-engine, if it is not provided.

The final files under flash/raft-engine should be:

>  ll ${TIFLASH_DATA_DIR}/flash/raft-engine
total 0
-rw-r--r--. 1 tidb tidb 0 Dec 16 17:02 ps_engine
-rw-r--r--. 1 tidb tidb 0 Dec 16 17:12 ps_engine.raftlog

image
image

What's Changed:


Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note


a
Signed-off-by: Calvin Neo <[email protected]>
@ti-chi-bot ti-chi-bot bot added the size/XS label Dec 16, 2024
v
Signed-off-by: Calvin Neo <[email protected]>
Copy link
Collaborator

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 17, 2024
Copy link

ti-chi-bot bot commented Dec 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-17 02:48:18.118924146 +0000 UTC m=+925088.207726688: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot added the approved label Dec 17, 2024
@CalvinNeo CalvinNeo merged commit 0fdd294 into pingcap:raftstore-proxy Dec 17, 2024
4 of 5 checks passed
CalvinNeo added a commit to CalvinNeo/tidb-engine-ext that referenced this pull request Dec 17, 2024
CalvinNeo added a commit to CalvinNeo/tidb-engine-ext that referenced this pull request Dec 17, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants