Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR solves the problem mentioned in #4684. Basically, we propose to use ERROR logs that report erroneous user input when rejecting them. In principle, any errors should be logged with ERROR (user error is no exception). Currently, INFO logs are used which makes it very difficult to identify those errors from a large number of INFO logs. This PR fixes the usage of the level of the log.
What is changed and how does it work?
We changed the level of
klog
fromInfof
toErrorf
where the log to be printed contains an error (err
in the code), whileInfof
is used for the log.Code changes
Tests
We believe this fix is straightforward since only the log level is changed and no test is needed.
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.