Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log level #4685

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix log level #4685

wants to merge 2 commits into from

Conversation

hoyhbx
Copy link
Contributor

@hoyhbx hoyhbx commented Aug 24, 2022

What problem does this PR solve?

This PR solves the problem mentioned in #4684. Basically, we propose to use ERROR logs that report erroneous user input when rejecting them. In principle, any errors should be logged with ERROR (user error is no exception). Currently, INFO logs are used which makes it very difficult to identify those errors from a large number of INFO logs. This PR fixes the usage of the level of the log.

What is changed and how does it work?

We changed the level of klog from Infof to Errorf where the log to be printed contains an error (err in the code), while Infof is used for the log.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

We believe this fix is straightforward since only the log level is changed and no test is needed.

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

NONE

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

Codecov Report

Merging #4685 (07767f1) into master (b84b18b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4685      +/-   ##
==========================================
- Coverage   63.58%   63.57%   -0.02%     
==========================================
  Files         196      196              
  Lines       21315    21315              
==========================================
- Hits        13554    13550       -4     
- Misses       6537     6539       +2     
- Partials     1224     1226       +2     
Flag Coverage Δ
unittest 63.57% <0.00%> (-0.02%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants