Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner/core: move all extra columns to the end in ExpandVirtualColumn #58499

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

planner/core: move all extra columns to the end in ExpandVirtualColumn #58499

wants to merge 3 commits into from
+44 −13

Conversation

joechenrh
Copy link
Contributor

@joechenrh joechenrh commented Dec 24, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #58475

Problem Summary:

What changed and how does it work?

As title. Previously we only move column with id ExtraHandleID to the end, but we forgot some other extra columns.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked labels Dec 24, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hawkingrei for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/planner SIG: Planner labels Dec 24, 2024
@tiprow tiprow
Copy link

tiprow bot commented Dec 24, 2024

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei
hawkingrei reviewed Dec 24, 2024
View reviewed changes
pkg/planner/core/integration_test.go Outdated
@@ -2318,3 +2318,23 @@ func TestNestedVirtualGeneratedColumnUpdate(t *testing.T) {
tk.MustExec("UPDATE test1 SET col7 = '{\"col10\":\"DDDDD\",\"col9\":[\"abcdefg\"]}';\n")
tk.MustExec("DELETE FROM test1 WHERE col1 < 0;\n")
}

// Issue 58475
func TestGeneratedColumnWithPartition(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this test case into pkg/planner/core/casetest/partition.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 24, 2024

@joechenrh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev 288e2bd link true /test check-dev
pull-integration-e2e-test 288e2bd link true /test pull-integration-e2e-test
idc-jenkins-ci-tidb/unit-test 288e2bd link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 288e2bd link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei left review comments

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

select failed for partition table with generated column with error needPartitionHandle != ret, tp(1)
2 participants
@joechenrh @hawkingrei