Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: move all extra columns to the end in ExpandVirtualColumn #58499

Merged
merged 5 commits into from
Dec 27, 2024

Conversation

joechenrh
Copy link
Contributor

@joechenrh joechenrh commented Dec 24, 2024

What problem does this PR solve?

Issue Number: close #58475, close #56013

Problem Summary:

What changed and how does it work?

As title. Previously we only move column with id ExtraHandleID to the end, but we forgot some other extra columns.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/planner SIG: Planner labels Dec 24, 2024
Copy link

tiprow bot commented Dec 24, 2024

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. and removed do-not-merge/needs-triage-completed labels Dec 27, 2024
@Defined2014 Defined2014 added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 27, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 27, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5801%. Comparing base (384f858) to head (0f2fc5d).
Report is 32 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #58499        +/-   ##
================================================
+ Coverage   73.5301%   73.5801%   +0.0500%     
================================================
  Files          1681       1680         -1     
  Lines        464298     470469      +6171     
================================================
+ Hits         341399     346172      +4773     
- Misses       102058     103337      +1279     
- Partials      20841      20960       +119     
Flag Coverage Δ
integration 42.9008% <100.0000%> (?)
unit 72.2565% <100.0000%> (-0.0471%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.5899% <ø> (-0.1727%) ⬇️

@Defined2014
Copy link
Contributor

/retest

Copy link

tiprow bot commented Dec 27, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Dec 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 27, 2024
Copy link

ti-chi-bot bot commented Dec 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-27 05:36:13.753922673 +0000 UTC m=+69509.109927315: ☑️ agreed by Defined2014.
  • 2024-12-27 07:49:40.37594266 +0000 UTC m=+77515.731947200: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit b11cce7 into pingcap:master Dec 27, 2024
23 of 24 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #58583.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #58584.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #58585.

@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
5 participants