Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CI TEST): move most packages to pkg/ #47457

Closed
wants to merge 24 commits into from

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented Oct 8, 2023

What problem does this PR solve?

Issue Number: ref #41241

Problem Summary:

What is changed and how it works?

As mentioned in #41241, this PR will move most of first-level packages to a new 'pkg' directory. However, dumpling and br are not moved since further discussions are needed.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test

    Just move files.

Side effects

  • NA

Documentation

  • No end-user documents update is needed, but we need to update some developer-faced documents.

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@bb7133 bb7133 requested a review from a team as a code owner October 8, 2023 09:37
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 8, 2023
@hawkingrei
Copy link
Member

/retest

bb7133 and others added 4 commits October 8, 2023 17:50
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
Copy link
Member

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/test all

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Oct 8, 2023

/test check-dev2

@tiprow
Copy link

tiprow bot commented Oct 8, 2023

@wuhuizuo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Oct 8, 2023

/test mysql-test


@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2023

@wuhuizuo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test unit-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test

In response to this:

/test mysql-test


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tiprow
Copy link

tiprow bot commented Oct 8, 2023

@wuhuizuo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test mysql-test


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Oct 8, 2023

/test mysql-test

@tiprow
Copy link

tiprow bot commented Oct 8, 2023

@wuhuizuo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Weizhen Wang <[email protected]>
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #47457 (e258f09) into feature/pkg (a98a02c) will increase coverage by 0.7150%.
The diff coverage is n/a.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           feature/pkg     #47457        +/-   ##
===================================================
+ Coverage      72.1473%   72.8624%   +0.7150%     
===================================================
  Files             1352       1403        +51     
  Lines           401072     409071      +7999     
===================================================
+ Hits            289363     298059      +8696     
+ Misses           92467      92247       -220     
+ Partials         19242      18765       -477     
Flag Coverage Δ
integration 39.5242% <ø> (?)
unit 72.3658% <ø> (+0.2184%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8612% <ø> (-4.3395%) ⬇️

hawkingrei and others added 8 commits October 9, 2023 13:36
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@tiprow
Copy link

tiprow bot commented Oct 10, 2023

@bb7133: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 5901468 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bb7133 and additionally assign xuhuaiyu, yudongusa, yujuncen for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bb7133 bb7133 deleted the branch pingcap:feature/pkg December 12, 2023 18:26
@bb7133 bb7133 closed this Dec 12, 2023
@bb7133 bb7133 deleted the feature/pkg branch December 12, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants