-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Run TestCompareReservedWordsWithMySQL in CI #48859
*: Run TestCompareReservedWordsWithMySQL in CI #48859
Conversation
Hi @dveeden. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This will fail until the test is fixed ( #48857 ) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #48859 +/- ##
================================================
- Coverage 70.2239% 60.6759% -9.5480%
================================================
Files 1452 1585 +133
Lines 420462 638447 +217985
================================================
+ Hits 295265 387384 +92119
- Misses 104836 229163 +124327
- Partials 20361 21900 +1539
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@dveeden: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…edWordsWithMySQL_CI
/test all |
/ok-to-test |
This can be done with Prow with these: |
Can you put this file into |
.github/workflows/mysql.yml
Outdated
@@ -0,0 +1,24 @@ | |||
name: MySQL Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main issue with this approach is that we are not paid users, so when the resources for actions are tight, the waiting time for tasks to start could be quite long. Although it should still be fine for running some temporary tasks. so we remove this file.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, mjonss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
What problem does this PR solve?
Issue Number: ref #48856
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.