Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Run TestCompareReservedWordsWithMySQL in CI #48859

Merged

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Nov 23, 2023

What problem does this PR solve?

Issue Number: ref #48856

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@dveeden dveeden requested review from bb7133 and mjonss November 23, 2023 15:26
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2023
Copy link

tiprow bot commented Nov 23, 2023

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dveeden
Copy link
Contributor Author

dveeden commented Nov 23, 2023

This will fail until the test is fixed ( #48857 )

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #48859 (87900e1) into master (6c4b1ea) will decrease coverage by 9.5480%.
Report is 338 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48859        +/-   ##
================================================
- Coverage   70.2239%   60.6759%   -9.5480%     
================================================
  Files          1452       1585       +133     
  Lines        420462     638447    +217985     
================================================
+ Hits         295265     387384     +92119     
- Misses       104836     229163    +124327     
- Partials      20361      21900      +1539     
Flag Coverage Δ
integration 42.4647% <ø> (?)
unit 75.3548% <ø> (+5.1308%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0571% <ø> (+0.0301%) ⬆️
parser ∅ <ø> (∅)
br 60.8170% <ø> (+10.3796%) ⬆️

@dveeden
Copy link
Contributor Author

dveeden commented Jan 23, 2024

/retest

Copy link

tiprow bot commented Jan 23, 2024

@dveeden: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/test all

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jan 23, 2024
@dveeden
Copy link
Contributor Author

dveeden commented Jan 23, 2024

This can be done with Prow with these:
tidb-test-reserved-words.zip

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 23, 2024
@hawkingrei
Copy link
Member

This can be done with Prow with these: tidb-test-reserved-words.zip

Can you put this file into build/image/parser_test?

@@ -0,0 +1,24 @@
name: MySQL Tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main issue with this approach is that we are not paid users, so when the resources for actions are tight, the waiting time for tasks to start could be quite long. Although it should still be fine for running some temporary tasks. so we remove this file.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 23, 2024
Copy link

ti-chi-bot bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, mjonss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 6, 2024
Copy link

ti-chi-bot bot commented Mar 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-23 15:24:06.017367701 +0000 UTC m=+887887.581665407: ☑️ agreed by mjonss.
  • 2024-03-06 04:23:22.269131787 +0000 UTC m=+227429.291378179: ☑️ agreed by hawkingrei.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit 748dbc9 into pingcap:master Mar 6, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants