Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: fix the test case by increase the time interval #51139

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Feb 19, 2024

What problem does this PR solve?

Issue Number: close #51142

Problem Summary:

What changed and how does it work?

img_v3_0287_9543bbb9-934b-4786-921a-c5c61c4a554g

We received some unstable test reports regarding certain cases. The instability arose from the fact that the case attempted to verify if the job had failed just by now. However, in some instances, if the test case was running slowly, it wouldn't be considered as just failing now because it is more than one second. To address this, we decided to omit the fail reason check in this PR. Additionally, we changed the timer intervals from 1 second to 10 seconds.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 19, 2024
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 19, 2024
Copy link

ti-chi-bot bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 19, 2024
Copy link

ti-chi-bot bot commented Feb 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-19 06:52:17.786564352 +0000 UTC m=+253626.534187448: ☑️ agreed by winoros.
  • 2024-02-19 06:53:17.728605596 +0000 UTC m=+253686.476228709: ☑️ agreed by hawkingrei.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Merging #51139 (eab88fa) into master (e3e0f7e) will increase coverage by 2.1242%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51139        +/-   ##
================================================
+ Coverage   70.5910%   72.7153%   +2.1242%     
================================================
  Files          1467       1467                
  Lines        434739     434794        +55     
================================================
+ Hits         306887     316162      +9275     
+ Misses       108594      98739      -9855     
- Partials      19258      19893       +635     
Flag Coverage Δ
integration 49.0239% <ø> (?)
unit 70.3580% <ø> (-0.0288%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.3788% <ø> (+5.5123%) ⬆️

@ti-chi-bot ti-chi-bot bot merged commit d96244d into pingcap:master Feb 19, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestIsValidToAnalyze
3 participants