Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dumpling: GCS always retry. #57513

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

OliverS929
Copy link
Contributor

@OliverS929 OliverS929 commented Nov 19, 2024

What problem does this PR solve?

Issue Number: close #56127

Problem Summary:

What changed and how does it work?

Always retry with GCS requests.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Nov 19, 2024
@sre-bot
Copy link
Contributor

sre-bot commented Nov 19, 2024

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 19, 2024
Copy link

tiprow bot commented Nov 19, 2024

Hi @OliverS929. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.4242%. Comparing base (22a175b) to head (d2849f4).
Report is 266 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57513        +/-   ##
================================================
+ Coverage   73.2236%   75.4242%   +2.2005%     
================================================
  Files          1649       1721        +72     
  Lines        455443     499292     +43849     
================================================
+ Hits         333492     376587     +43095     
+ Misses       101479     100053      -1426     
- Partials      20472      22652      +2180     
Flag Coverage Δ
integration 50.0778% <100.0000%> (?)
unit 72.6405% <100.0000%> (+0.1326%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (-0.1806%) ⬇️
parser ∅ <ø> (∅)
br 62.9164% <100.0000%> (+16.9175%) ⬆️

@OliverS929
Copy link
Contributor Author

/test pull-br-integration-test

Copy link

tiprow bot commented Nov 19, 2024

@OliverS929: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 20, 2024
Copy link

ti-chi-bot bot commented Nov 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-19 11:31:00.758229975 +0000 UTC m=+960622.949098969: ☑️ agreed by Benjamin2037.
  • 2024-11-20 06:57:42.687611115 +0000 UTC m=+14850.307265628: ☑️ agreed by GMHDBJD.

Copy link

tiprow bot commented Nov 20, 2024

@OliverS929: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow d2849f4 link true /test fast_test_tiprow
tidb_parser_test d2849f4 link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@D3Hunter
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2024
@D3Hunter
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2024
@lance6716
Copy link
Contributor

please sign CLA

@OliverS929
Copy link
Contributor Author

please sign CLA

Done.

@ti-chi-bot ti-chi-bot bot merged commit 84fe10a into pingcap:master Nov 20, 2024
37 of 39 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #57561.

ti-chi-bot bot pushed a commit that referenced this pull request Nov 21, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 3, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #57924.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 3, 2024
@OliverS929 OliverS929 deleted the 2411dumplingfix branch December 12, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dumpling will not retry upload to GCS if the server returned 503
7 participants