Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix debug decode backupmeta (#56627) #57891

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #56627

What problem does this PR solve?

Issue Number: close #56296

Problem Summary:
We can only see the main backupmeta.json.

What changed and how does it work?

decode the meta file and stats file.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
$ ls -aF1 /tmp/testbr
./
../
1/
backup.lock
backupmeta
backupmeta.datafile.000000001
backupmeta.schema.000000002
backupmeta.schema.stats.000000110
jsons/

$ ls -aF1 /tmp/testbr/jsons
./
../
backupmeta.datafile.000000001.json
backupmeta.json
backupmeta.schema.000000002.json
backupmeta.schema.stats.000000110.json
backupmeta.datafile.000000001.json

{
  "data_files": [
    {
      "name":"..",
      "sha256":"lu4KiCseT0M6dG2gghZXDwD5WOUOqDMhYKcLHMuDYGA=",
      "start_key":"..",
      "end_key":"..",
      "end_version":452625823236882437,
      "crc64xor":17088955387164552884,
      "total_kvs":1,
      "total_bytes":47,
      "cf":"write",
      "size":1673,
      "cipher_iv":..,
    },
    ...
  ],
}
backupmeta.schema.000000002.json

{
  "schemas":[
    {
      "db": ..,
      "table": ..,
      "crc64xor":4505190652257934775,
      "total_kvs":32,
      "total_bytes":3031,
    },
    ...
  ],
}
backupmeta.schema.stats.000000110.json

{
  "blocks":[
    {
      "physical_id":110,
      "json_table": ..,
    },
}
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Dec 2, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 2, 2024
13 tasks
Signed-off-by: Jianjun Liao <[email protected]>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 46.08696% with 62 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@e62cfd5). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #57891   +/-   ##
================================================
  Coverage               ?   72.1689%           
================================================
  Files                  ?       1416           
  Lines                  ?     413247           
  Branches               ?          0           
================================================
  Hits                   ?     298236           
  Misses                 ?      95021           
  Partials               ?      19990           
Flag Coverage Δ
unit 72.1689% <46.0869%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.5253% <0.0000%> (?)

Copy link

ti-chi-bot bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 12, 2024
Copy link

ti-chi-bot bot commented Dec 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-12 04:57:47.78457429 +0000 UTC m=+500857.873376834: ☑️ agreed by Leavrth.
  • 2024-12-12 05:06:56.258256969 +0000 UTC m=+501406.347059507: ☑️ agreed by 3pointer.

@ti-chi-bot ti-chi-bot bot merged commit 4df9aa8 into pingcap:release-7.5 Dec 12, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants