Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domain: change some stats log level as WARN #58316

Merged
merged 1 commit into from
Dec 17, 2024
Merged

domain: change some stats log level as WARN #58316

merged 1 commit into from
Dec 17, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Dec 17, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #58315

Problem Summary:

What changed and how does it work?

want to know the reason why this function will be failed.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

change some stats log level as WARN 

修改部分 stats 日志为 WARN 级别

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Dec 17, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.9925%. Comparing base (57a73ea) to head (3c0a605).
Report is 96 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #58316        +/-   ##
================================================
+ Coverage   73.2342%   74.9925%   +1.7582%     
================================================
  Files          1679       1724        +45     
  Lines        462360     470492      +8132     
================================================
+ Hits         338606     352834     +14228     
+ Misses       102972      95461      -7511     
- Partials      20782      22197      +1415
Flag Coverage Δ
integration 49.0546% <0.0000%> (?)
unit 72.3689% <0.0000%> (+0.0048%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 61.6545% <ø> (+15.6375%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 17, 2024
@lance6716
Copy link
Contributor

/hold

Also use sampled logger to reduce log size if they are failed for a long time. Free to unhold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2024
@hawkingrei
Copy link
Member Author

/hold

Also use sampled logger to reduce log size if they are failed for a long time. Free to unhold

They are all controlled by timers, and the interval is at the second level, so there won't be too many logs. In fact, if there is a problem for a long time, too many logs can also help them trigger the log warn alarm.

@hawkingrei
Copy link
Member Author

/pull-br-integration-test

@hawkingrei
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 17, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-17 04:50:13.926683384 +0000 UTC m=+932404.015485912: ☑️ agreed by lance6716.
  • 2024-12-17 06:35:27.834081101 +0000 UTC m=+938717.922883632: ☑️ agreed by winoros.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, qw4990, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 664805a into pingcap:master Dec 17, 2024
26 checks passed
@hawkingrei
Copy link
Member Author

/cherrypick release-6.5
/cherrypick release-7.1
/cherrypick release-7.5
/cherrypick release-8.1
/cherrypick release-8.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-6.5: #58551.

In response to this:

/cherrypick release-6.5
/cherrypick release-7.1
/cherrypick release-7.5
/cherrypick release-8.1
/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 26, 2024
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#58316
c78e64b 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 26, 2024
Merged
13 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.1: #58552.

In response to this:

/cherrypick release-6.5
/cherrypick release-7.1
/cherrypick release-7.5
/cherrypick release-8.1
/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 26, 2024
Merged
13 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #58553.

In response to this:

/cherrypick release-6.5
/cherrypick release-7.1
/cherrypick release-7.5
/cherrypick release-8.1
/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 26, 2024
Open
13 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #58554.

In response to this:

/cherrypick release-6.5
/cherrypick release-7.1
/cherrypick release-7.5
/cherrypick release-8.1
/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 26, 2024
Open
13 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.5: #58555.

In response to this:

/cherrypick release-6.5
/cherrypick release-7.1
/cherrypick release-7.5
/cherrypick release-8.1
/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 26, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 27, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Dec 27, 2024
@ti-chi-bot
domain: change some stats log level as WARN (#58316) (#58552)
92720ee 
ref #58315
ti-chi-bot bot pushed a commit that referenced this pull request Dec 27, 2024
@ti-chi-bot
domain: change some stats log level as WARN (#58316) (#58551)
1bdef59 
ref #58315
ti-chi-bot bot pushed a commit that referenced this pull request Dec 27, 2024
@ti-chi-bot
domain: change some stats log level as WARN (#58316) (#58555)
eaa8c33 
ref #58315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@qw4990 qw4990 qw4990 approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hawkingrei @lance6716 @ti-chi-bot @qw4990 @winoros