-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttl: set the job history status to cancelled
if it's removed in GC and it's still running (#58539)
#58711
ttl: set the job history status to cancelled
if it's removed in GC and it's still running (#58539)
#58711
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: Yang Keao <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #58711 +/- ##
================================================
Coverage ? 56.9023%
================================================
Files ? 1770
Lines ? 627060
Branches ? 0
================================================
Hits ? 356812
Misses ? 246110
Partials ? 24138
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR depends on #57827 |
/hold |
/unhold |
…58539-to-release-8.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #58539
What problem does this PR solve?
Issue Number: close #58510
Problem Summary:
The job history is not updated after removing the table status. Therefore, the timer adapter will still believe there is a job running for it.
What changed and how does it work?
Update the status to
cancelled
after removing the table status.Check List
Tests
Release note