globalsort: skip retry when context has error

[lance6716]

What problem does this PR solve?

Issue Number: close #58826

Problem Summary:

What changed and how does it work?

just a log improvement

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.8477%. Comparing base (448e302) to head (558e43d).
Report is 16 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #58828        +/-   ##
================================================
+ Coverage   73.1515%   73.8477%   +0.6962%     
================================================
  Files          1677       1707        +30     
  Lines        463907     474334     +10427     
================================================
+ Hits         339355     350285     +10930     
+ Misses       103699     102467      -1232     
- Partials      20853      21582       +729     

Flag	Coverage Δ
integration	45.6907% <0.0000%> (?)
unit	72.3397% <100.0000%> (-0.0208%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.6910% <ø> (ø)
parser	∅ <ø> (∅)
br	45.7659% <ø> (+0.0299%)	⬆️

[lance6716]

/retest

[tiprow]

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Benjamin2037]

Normally, Can we know which errors that ctx may occur during global sort period? Dose all of them can cause tasks return?

[lance6716]

here I didn't want to check error. I check that user context is canceled (although the interface is ctx.Err()). When context is canceled, this for loop will run flushKVsRetryTimes times but immediately flushSortedKVs will return because of ctx.Err(), and below log line will be printed unnecessarily.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, joccau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/lightning/OWNERS [D3Hunter]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-01-13 02:18:31.062587287 +0000 UTC m=+752054.351418992: ☑️ agreed by D3Hunter.
• 2025-01-13 03:10:32.306646783 +0000 UTC m=+755175.595478512: ☑️ agreed by joccau.