-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: support capturing to and replaying from shared storage #58862
Conversation
Hi @djshow832. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #58862 +/- ##
================================================
+ Coverage 73.0869% 73.7030% +0.6160%
================================================
Files 1676 1678 +2
Lines 463749 469731 +5982
================================================
+ Hits 338940 346206 +7266
+ Misses 103956 102594 -1362
- Partials 20853 20931 +78
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@djshow832: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #58861
Problem Summary:
Support writing traffic files to shared storage so that users don't need to copy files from the production cluster to the testing cluster.
What changed and how does it work?
tiproxy-0
,tiproxy-1
, ...Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.