Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: Release 8.5 20250114 v8.5.0 #58981

Open
wants to merge 14 commits into
base: release-8.5-20250114-v8.5.0
Choose a base branch
from

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Jan 16, 2025

What problem does this PR solve?

Issue Number: N/A

Problem Summary:
This hotfix includes patches needed by the compatibility between log backup and restore snapshot.

What changed and how does it work?

The following PRs are picked:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 16, 2025
Copy link

tiprow bot commented Jan 16, 2025

Hi @YuJuncen. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 39.13548% with 2098 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5-20250114-v8.5.0@ad2e1cd). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                        @@
##             release-8.5-20250114-v8.5.0     #58981   +/-   ##
================================================================
  Coverage                               ?   23.8338%           
================================================================
  Files                                  ?       1683           
  Lines                                  ?     610639           
  Branches                               ?          0           
================================================================
  Hits                                   ?     145539           
  Misses                                 ?     446671           
  Partials                               ?      18429           
Flag Coverage Δ
integration 23.8338% <39.1354%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling ∅ <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 34.0853% <0.0000%> (?)

BornChanger
BornChanger previously approved these changes Jan 16, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 16, 2025
D3Hunter
D3Hunter previously approved these changes Jan 16, 2025
@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 16, 2025
Copy link

ti-chi-bot bot commented Jan 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-16 08:01:55.125226184 +0000 UTC m=+191986.580272344: ☑️ agreed by BornChanger.
  • 2025-01-16 08:17:53.083310257 +0000 UTC m=+192944.538356401: ☑️ agreed by D3Hunter.

@YuJuncen YuJuncen dismissed stale reviews from D3Hunter and BornChanger via f342b7c January 16, 2025 10:02
Copy link

ti-chi-bot bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from yujuncen and additionally assign d3hunter for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the approved label Jan 16, 2025
Copy link

ti-chi-bot bot commented Jan 16, 2025

@YuJuncen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test f342b7c link true /test unit-test
idc-jenkins-ci-tidb/build f342b7c link true /test build
idc-jenkins-ci-tidb/check_dev f342b7c link true /test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants