Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error when first argument of replace function is const #9615

Merged
merged 13 commits into from
Nov 18, 2024
Merged

fix error when first argument of replace function is const #9615

merged 13 commits into from
Nov 18, 2024

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Nov 14, 2024 •
edited by yibin87
Loading

What problem does this PR solve?

Issue Number: close #9522

Problem Summary:

What is changed and how it works?

1. remove some useless arguments(pos, occ, match_type)
2. support first argument as ColumnConst

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix error when first argument of replace function is const

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2024
@guo-shaoge
fix
9f61b0e 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge guo-shaoge changed the title fix when first argument of replace function is column const fix when first argument of replace function is const Nov 15, 2024
@guo-shaoge guo-shaoge changed the title fix when first argument of replace function is const fix error when first argument of replace function is const Nov 15, 2024
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 15, 2024
@guo-shaoge
fmt
ba80e35 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
fix
0f7faf8 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
refine
4b56d6d 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
fix
6a1a480 
Signed-off-by: guo-shaoge <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2024
@guo-shaoge
fix
f02a230 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
fix
571e2dc 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
refine
a2b914e 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
refine
284e46b 
Signed-off-by: guo-shaoge <[email protected]>
@guo-shaoge
fix
7a2f869 
Signed-off-by: guo-shaoge <[email protected]>
yibin87
yibin87 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add uts, others LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 18, 2024
@guo-shaoge
unit test
eb65b34 
Signed-off-by: guo-shaoge <[email protected]>
windtalker
windtalker approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 18, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 18, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-18 02:13:28.763583644 +0000 UTC m=+840770.954452637: ☑️ agreed by yibin87.
  • 2024-11-18 05:57:45.979421916 +0000 UTC m=+854228.170290905: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 18, 2024

@guo-shaoge: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@guo-shaoge
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 11ce13f into pingcap:master Nov 18, 2024
5 checks passed
@guo-shaoge guo-shaoge added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Nov 18, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 18, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Nov 18, 2024
@guo-shaoge @ti-chi-bot
This is an automated cherry-pick of pingcap#9615
95fb61f 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #9641.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2024
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9642.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2024
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9643.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Nov 18, 2024
@guo-shaoge @ti-chi-bot
This is an automated cherry-pick of pingcap#9615
046e76b 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9644.

This was referenced Nov 18, 2024
Closed
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9645.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Nov 18, 2024
@guo-shaoge @ti-chi-bot
This is an automated cherry-pick of pingcap#9615
ee676e1 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2024
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #9646.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Nov 18, 2024
@ti-chi-bot @guo-shaoge
fix error when first argument of replace function is const (#9615) (#…
7bee6e8 
…9646)

close #9522

1. remove some useless arguments(pos, occ, match_type)
2. support first argument as ColumnConst

Signed-off-by: guo-shaoge <[email protected]>

Co-authored-by: guo-shaoge <[email protected]>
@JaySon-Huang JaySon-Huang deleted the fix_replace branch November 20, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yibin87 yibin87 yibin87 approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run sql failed when using replace function
4 participants
@guo-shaoge @ti-chi-bot @windtalker @yibin87