Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl(ticdc): support restoring add index statements with pre-split option #11926

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Dec 23, 2024

What problem does this PR solve?

Issue Number: close #11927

TiDB PR: pingcap/tidb#58408

What is changed and how it works?

  • Upgrade TiDB & parser dependency.
  • Add a test for special comment.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-linked-issue labels Dec 23, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, asddongmen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 23, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-23 09:38:46.791876602 +0000 UTC m=+1468116.880679141: ☑️ agreed by asddongmen.
  • 2024-12-23 09:40:48.659187018 +0000 UTC m=+1468238.747989560: ☑️ agreed by 3AceShowHand.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 24, 2024
This reverts commit f1f9326.
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 24, 2024
@purelind
Copy link
Collaborator

/test cdc-integration-mysql-test

@purelind
Copy link
Collaborator

/test engine-integration-test

@tangenta
Copy link
Contributor Author

/retest

1 similar comment
@asddongmen
Copy link
Contributor

/retest

@tangenta
Copy link
Contributor Author

/retest

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Dec 25, 2024

/retest

Copy link
Contributor

ti-chi-bot bot commented Dec 25, 2024

@tangenta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-engine-integration-test 3555d4f link true /test engine-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TiCDC should support restoring pre-split index option
5 participants