Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose preferred locations config #2762

Merged
merged 13 commits into from
Oct 9, 2023

Conversation

shiyuhang0
Copy link
Member

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from shiyuhang0. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XS and removed size/XL labels Oct 7, 2023
@ti-chi-bot ti-chi-bot bot added size/S and removed size/XS labels Oct 7, 2023
@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0 shiyuhang0 changed the title Balance and log Expose preferred locations config Oct 7, 2023
@shiyuhang0
Copy link
Member Author

/run-all-tests

1 similar comment
@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/run-all-tests tikv=v6.5.0 tidb=v6.5.0 pd=v6.5.0

@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=v6.1.0 tikv=v6.1.0 pd=v6.1.0

@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/run-all-tests tidb=v7.1.0 tikv=v7.1.0 pd=v7.1.0

@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/run-all-tests

1 similar comment
@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0 shiyuhang0 added the needs-cherry-pick-master PR which needs to be cherry-picked to master label Oct 9, 2023
@shiyuhang0 shiyuhang0 merged commit 53f79a7 into pingcap:release-3.2 Oct 9, 2023
1 of 3 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch master: #2765.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Oct 9, 2023
@shiyuhang0
Copy link
Member Author

/cherry-pick master

@ti-chi-bot
Copy link
Member

@shiyuhang0: new pull request could not be created: failed to create pull request against pingcap/tispark#master from head ti-chi-bot:cherry-pick-2762-to-master: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for ti-chi-bot:cherry-pick-2762-to-master."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"}

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Oct 9, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-master PR which needs to be cherry-picked to master size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants