-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DMN] playground: add dm support for playground #2464
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Siddon Tang <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
// this is a very ugly implementation, but it may mostly works | ||
// TODO: find a better way to do this, | ||
// e.g, let master support a HTTP API to check if it's ready | ||
time.Sleep(time.Second * 3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Benjamin2037 seems that for DM worker, we should support Retry when the worker starts and tries to connect the leader of the Master.
In the case of Playground, when the master starts, and the worker will also immediately start, and the worker will fail because at that time, there is no leader in DM master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing with the TiUP owner, we decided to use TiUP first to start the DM master and wait for all DM master starting processes to finish, and then TiUP starts the DM worker.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Try to support DM in playground.
Notice, this is just a trail, a simple reference for the people who really will do this work later.
What is changed and how it works?
create a DM mastesr and worker.
Check List
Tests
Code changes
none
Side effects
none
Related changes
Release notes: