Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DMN] playground: add dm support for playground #2464

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

siddontang
Copy link
Member

What problem does this PR solve?

Try to support DM in playground.

Notice, this is just a trail, a simple reference for the people who really will do this work later.

What is changed and how it works?

tiup-playground nightly --dm-master 1 --dm-worker 1

create a DM mastesr and worker.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

none

Side effects

none

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

Add DM support for TiUP playground

@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2024
@ti-chi-bot ti-chi-bot bot requested review from breezewish and kaaaaaaang October 28, 2024 08:29
Copy link
Contributor

ti-chi-bot bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 28, 2024
// this is a very ugly implementation, but it may mostly works
// TODO: find a better way to do this,
// e.g, let master support a HTTP API to check if it's ready
time.Sleep(time.Second * 3)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Benjamin2037 seems that for DM worker, we should support Retry when the worker starts and tries to connect the leader of the Master.

In the case of Playground, when the master starts, and the worker will also immediately start, and the worker will fail because at that time, there is no leader in DM master.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussing with the TiUP owner, we decided to use TiUP first to start the DM master and wait for all DM master starting processes to finish, and then TiUP starts the DM worker.

Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants