forked from bcoin-org/bcoin
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mempool: log is rbf with hash and mempool size #12
Open
tynes
wants to merge
7
commits into
pinheadmz:rbf1
Choose a base branch
from
tynes:rbf2
base: rbf1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Oct 14, 2019
-
mempool: Allow double spend of RBF transaction
"Quick and dirty" isDoubleSpend() check evaluates to false if the conflicting tx has opted in to RBF. More verbose checks are still required for BIP125. General RBF tests added.
Configuration menu - View commit details
-
Copy full SHA for 440bfc6 - Browse repository at this point
Copy the full SHA 440bfc6View commit details -
mempool: Reject RBF replacements with insufficient fees
Implements and tests BIP125 rules specifically pertaining to fee requirements for replacement transactions. Valid replacements must pay a higher fee rate than the original TX, and also must pay for the bandwidth of all potentially evicted transactions in addition to its own bandwidth.
Configuration menu - View commit details
-
Copy full SHA for 5c9f4d4 - Browse repository at this point
Copy the full SHA 5c9f4d4View commit details -
mempool: Reject RBF replacement edge cases
Implements two extra rules defined in BIP125: - The replacement transaction may only include an unconfirmed input if that input was included in one of the original transactions. - The number of original transactions to be replaced and their descendant transactions which will be evicted from the mempool must not exceed a total of 100 transactions.
Configuration menu - View commit details
-
Copy full SHA for 6a01cd1 - Browse repository at this point
Copy the full SHA 6a01cd1View commit details -
All the BIP125 rules have been implemented to reject invalid replacement TXs. This is where the actual replacement happens, adding the replacement TX and evicting all the conflicts and their descendants.
Configuration menu - View commit details
-
Copy full SHA for 69921bf - Browse repository at this point
Copy the full SHA 69921bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d5ff9b - Browse repository at this point
Copy the full SHA 3d5ff9bView commit details
Commits on Oct 15, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 2a2c3de - Browse repository at this point
Copy the full SHA 2a2c3deView commit details -
mempool: log is rbf with hash and mempool size
Mark Tyneway committedOct 15, 2019 Configuration menu - View commit details
-
Copy full SHA for 98500ab - Browse repository at this point
Copy the full SHA 98500abView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.