Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regression with showing standard keys in output object if they contain escaped dot #490

Closed
wants to merge 1 commit into from
Closed

fix: regression with showing standard keys in output object if they contain escaped dot #490

wants to merge 1 commit into from

Conversation

paulish
Copy link

@paulish paulish commented Jan 24, 2024

fixes issue #456

jsumners
jsumners requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Missing unit tests.
  2. Current tests are failing.

@ademarsj
Copy link
Contributor

It seems this has already been fixed by another Pull Request(#538).
Maybe discard this PR?

@mcollina mcollina closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners jsumners jsumners requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulish @ademarsj @jsumners @mcollina