Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add periodicFlush option #200

Merged
merged 2 commits into from
Sep 2, 2024
Merged

add periodicFlush option #200

merged 2 commits into from
Sep 2, 2024

Conversation

forgotPassword
Copy link
Contributor

fixes #193

mcollina
mcollina requested changes Aug 6, 2024
View reviewed changes
README.md Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
test/periodicflush.test.js Show resolved Hide resolved
@forgotPassword
Copy link
Contributor Author

added suggested changes

mcollina
mcollina approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@forgotPassword
Copy link
Contributor Author

forgotPassword commented Aug 6, 2024 •
edited
Loading

should _periodicFlush be periodicFlush? but then there is _fsync. also some tests (before my changes) are flaky on wsl, don't know if it's a problem

 FAIL  test/write.test.js 4 failed of 120 19s
 ✖ sync true > write things to a file descriptor > EBADF: bad file descriptor, close
    code: EBADF
    errno: -9
    syscall: close
    tapCaught: uncaughtException

@mcollina mcollina merged commit fec592f into pinojs:master Sep 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronag ronag ronag approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an option for periodic flush
3 participants
@forgotPassword @mcollina @ronag