Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PrivacyInfo.xcprivacy #325

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Add PrivacyInfo.xcprivacy #325

merged 2 commits into from
Apr 24, 2024

Conversation

garricn
Copy link
Contributor

@garricn garricn commented Mar 21, 2024

Addresses #324.

See Describing use of required reason API for more information.

Required Reason API Used Used in File
NSFileModificationDate PINCache/Source/PINDiskCache.m
NSFileModificationDate PINCache/Tests/PINCacheTests.m
NSURLContentModificationDateKey PINCache/Source/PINDiskCache.m
NSURLCreationDateKey PINCache/Source/PINDiskCache.m

@hotngui
Copy link

hotngui commented Apr 1, 2024

The PrivacyInfo.xcprivacy file also needs to be added to the Package.swift file as a resource to by copied/processed.

@EFFYLYX
Copy link

EFFYLYX commented Apr 15, 2024

When would you like to merge this PR?

@garricn
Copy link
Contributor Author

garricn commented Apr 17, 2024

When would you like to merge this PR?

Hi @EFFYLYX. Thank you for replying. It would be great if this PR can merge now. Are you able to merge it?

@farzadshbfn
Copy link

@tinder-owenthomas any chance of merging this PR soon? we're approaching the deadline and it's good to give teams lead-time on updating their frameworks'.

@jparise jparise merged commit f856226 into pinterest:master Apr 24, 2024
6 checks passed
@jparise
Copy link
Collaborator

jparise commented Apr 24, 2024

This change looks reasonable to me, so I'll help move things along by merging this. That will also give time for folks to adopt this change and provide feedback on anything that might need to be adjusted.

@gazadge
Copy link

gazadge commented Apr 29, 2024

Hey @jparise,
I added a new PR related to this issue for including the .xcprivacy file as resource when installing PINCache via Cocoapods. When you get a chance can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants