Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the optimization to reduce the display links frame interval #528

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

garrettmoon
Copy link
Collaborator

The idea behind this optimization was to reduce the number of calls the display
link would need for animated images which didn't draw every frame. But this
has resulted in frames being dropped in certain cases where frameInterval isn't
respected (see https://i.pinimg.com/originals/58/9c/e8/589ce828d2ef0797da0e85b1c6d2f2b3.gif)

Since the the display link fire method continues if we detect we're
at the same image index as before, let's just remove this optimization.

The idea behind this optimization was to reduce the number of calls the display
link would need for animated images which didn't draw every frame. But this
has resulted in frames being dropped in certain cases where frameInterval isn't
respected (see https://i.pinimg.com/originals/58/9c/e8/589ce828d2ef0797da0e85b1c6d2f2b3.gif)

Since the the display link fire method continues if we detect we're
at the same image index as before, let's just remove this optimization.
@ghost
Copy link

ghost commented Aug 2, 2019

1 Warning
⚠️ Any source code changes should have an entry in CHANGELOG.md or have #trivial in their title.

Generated by 🚫 Danger

@ghost
Copy link

ghost commented Aug 2, 2019

🚫 CI failed with log

@bolsinga
Copy link
Contributor

Is it possible to add a test covering this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants