Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox, ComboBox, Fieldset, Image, Pog, RadioButton, RadioGroup, RadioGroupButton, SearchField, TextField: Adding data test id #3736

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

elnanni
Copy link
Contributor

@elnanni elnanni commented Sep 6, 2024

Summary

Adding data test id for Checkbox, ComboBox, Fieldset, Image, Pog, RadioButton, RadioGroup, RadioGroupButton, SearchField, TextField Gestalt components

What changed?

New prop dataTestId for Gestalt components
At a high level, what changes does this PR introduce?
Adding a new prop for some Gestalt components

Why?

To improve integration testing speed and accuracy

Links

  • Jira
  • TDD
  • [Figma](link to Figma file)

Checklist

  • Added unit tests
  • Added documentation + accessibility tests
  • Verified accessibility: keyboard & screen reader interaction
  • Checked dark mode, responsiveness, and right-to-left support
  • Checked stakeholder feedback (e.g. Gestalt designers, relevant feature teams)

…dioGroupButton, SearchField, TextField: Adding data test id
Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for gestalt ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4cb3e9d
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/66edfc97a4da0c0008799f9c
😎 Deploy Preview https://deploy-preview-3736--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@elnanni elnanni marked this pull request as ready for review September 6, 2024 08:44
@elnanni elnanni requested a review from a team as a code owner September 6, 2024 08:44
@AlbertCarreras AlbertCarreras added the minor release Minor release label Sep 9, 2024
…utton, RadioGroupButton, SearchField: data test id updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor release Minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants