Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance s3 object key formatting #457

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Enhance s3 object key formatting #457

merged 1 commit into from
Dec 3, 2024

Conversation

jfzunigac
Copy link
Contributor

Enhance the s3Key building function:

  1. Utilize StringSubstitutor from apache-commons library for token replacement
  2. Add Year, Month, Day, Hour, Minute, Seconds to default tokens for more granular date/time prefixing
  3. Allow environment variables to be replaced into s3Key
  4. Change formatting for tokens:
    - %{} will continue to be used for regex tokens
    - {{}} will now be used for default tokens
    - ${} will be used for environment variables

@jfzunigac jfzunigac requested a review from a team as a code owner December 3, 2024 20:06
@jfzunigac jfzunigac merged commit 5363358 into pinterest:master Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vahidhashemian vahidhashemian vahidhashemian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfzunigac @vahidhashemian