Refactor Http Client implementation #1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
deploy-service/universal/src/main/java/com/pinterest/teletraan/universal/http/HttpClient.java
Fixed
Show fixed
Hide fixed
tylerwowen
force-pushed
the
touyang/http
branch
from
24f64a1
to
e9cfb1f
Compare
osoriano
reviewed
Nov 12, 2024
...service/universal/src/main/java/com/pinterest/teletraan/universal/http/RetryInterceptor.java
Show resolved
Hide resolved
osoriano
reviewed
Nov 12, 2024
deploy-service/common/src/main/java/com/pinterest/deployservice/common/Jenkins.java
Outdated
Show resolved
Hide resolved
osoriano
previously approved these changes
Nov 12, 2024
osoriano
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the implementation using java.net with OkHttp.
The current HTTP client has various issues. Instead of pathing the existing implementations, it's better to use another client library. OkHTTPClient is one of the most popular one and it's used by PinDeploy and Spinnaker.
Improvements
Tests and validations
Thanks to the added observability, it's very easy to know and monitor if this refactoring is working in addition to the unit tests.
Smoke tests
Deploy both service and worker to dev1 and ensure these are working
Additional details
Various logging levels
Basic
Body and header
Metrics