-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log-normal log-likelihood #1378
Conversation
partly addresses #1376
Codecov Report
@@ Coverage Diff @@
## master #1378 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 95 95
Lines 9282 9321 +39
=========================================
+ Hits 9282 9321 +39
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good @ben18785 ! I like the Boolean for switching between the means. I just have a couple minor comments and a general comment on testing.
Adds a log-normal distribution both without (default) and with mean-adjustment as described in #1376