-
-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): add keybinding for target radial #5962
feat(ui): add keybinding for target radial #5962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks simple enough - I have only one spot where I'd prefer some cleanup be done to increase the future maintainability of the code.
I cannot promise a timeline, but I'll be working on allowing Lua to register inputs without the need for the C++-side AddActionBinding
calls.
It appears the timeline was <12hrs... should I update this PR to make use of the new API? |
The only thing that's currently missing to do so is a nice place to hang a Lua-side InputFrame off of - we don't currently have a good way to track when the WorldView is made active and push/pop an InputFrame in response. Some work would likely be needed to amend I leave it at your discretion whether you want to merge this first, then convert all of the radial menu keybinds as described, or expand the scope of this PR and tackle all of the above in this PR. |
Let's keep the scope to the actual feature for now; please merge if acceptable and I'll create a TODO ticket to put in the relevant plumbing and upgrade all radial menus / Lua keybinds in a clean-up ticket. |
Add a keybinding to open the target radial menu. The bind is empty by default as per the other target radials. This allows keyboard controls to fly to, orbit, or dock with the current frame object or nav target, as appropriate.
894b7ad
to
10b0112
Compare
Merged, thanks! |
Add a keybinding to open the target radial menu. The bind is empty by default as per the other target radials.
This allows keyboard controls to fly to, orbit, or dock with the current frame object or nav target, as appropriate.