-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More work on llm-as-judge phrase endpointing #688
Conversation
return isinstance(frame, SystemFrame) | ||
# Ignore system frames and frames that are not following the direction of this gate | ||
def _should_passthrough_frame(self, frame, direction): | ||
return isinstance(frame, SystemFrame) or direction != self._direction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Yes, I remember doing this in the gated aggregator.
@kwindla @aconchillo |
4c2f104
to
33931c1
Compare
33931c1
to
335178f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice improvement upon the work @aconchillo did. I think we should merge it and continue to improve the functionality and prompting as we learn more.
Some proposed/possible additions to the "natural conversation" phrase endpointing:
The llm-as-judge performance is better in this version, I think. Latency is also lower.
There are at least two bugs to fix:
LLMMessagesFrame
. That's easy to fix.