Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toggle looping with soundfile mixer #693

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

jamsea
Copy link
Contributor

@jamsea jamsea commented Nov 6, 2024

This allows a user to toggle looping audio when creating the mixer or dynamically with a control frame like this:

await task.queue_frame(MixerUpdateSettingsFrame({"sound": "ding", "loop": False}))

This allows users to trigger sound effects that aren't meant to be looped, e.g. a "ding" when a participant joins a call.

@aconchillo
Copy link
Contributor

Just made a coupld of comments, but looks good! Thank you! 🙏

@aconchillo aconchillo merged commit d566672 into main Nov 8, 2024
3 checks passed
@aconchillo aconchillo deleted the hush/disableLoopAudio branch November 8, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants