Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RimeHttpTTSService #708

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Add RimeHttpTTSService #708

merged 2 commits into from
Nov 12, 2024

Conversation

markbackman
Copy link
Contributor

Please describe the changes in your PR. If it is addressing an issue, please reference that as well.

Adding Rime, a new TTS service. They only support HTTP interaction at the moment.

@markbackman
Copy link
Contributor Author

markbackman commented Nov 12, 2024 •
edited
Loading

@aconchillo this is the first service that I've added that doesn't have any new package dependencies. How should we treat that in terms of installing the service? Perhaps nothing is required...

@aconchillo
Copy link
Contributor

@aconchillo this is the first service that I've added that doesn't have any new package dependencies. How should we treat that in terms of installing the service? Perhaps nothing is required...

Nothing is required.

aconchillo
aconchillo reviewed Nov 12, 2024
View reviewed changes
src/pipecat/services/rime.py Outdated
from pipecat.services.ai_services import TTSService


class RimeTTSService(TTSService):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably call it RimeHttpTTSService so we don't have to rename if they ever support websockets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I got a message from the Rime founder today and they're working on a websocket service. I'll update the name since the websocket service will be coming in the future.

aconchillo
aconchillo reviewed Nov 12, 2024
View reviewed changes
CHANGELOG.md Outdated

### Added

- Added `RimeTTSService` and the `07q-interruptible-rime.py` foundational
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update if you rename.

@aconchillo
Copy link
Contributor

LGTM! Just added one comment.

@markbackman markbackman changed the title Add RimeTTSService Add RimeHttpTTSService Nov 12, 2024
@markbackman markbackman merged commit 0af2196 into main Nov 12, 2024
3 checks passed
@markbackman markbackman deleted the mb/add-rime-ai branch November 12, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aconchillo aconchillo aconchillo approved these changes

@kwindla kwindla Awaiting requested review from kwindla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markbackman @aconchillo