Update Contributor PhoneNumber nullability for consistency (ardalis#686)

* Adjust PhoneNumber nullability throughout layers

* remove wwwroot from csproj

* add LINQ expression back in for in memory provider

src/Clean.Architecture.Infrastructure/Data/Queries/ListContributorsQueryService.cs

@@ -12,8 +12,8 @@ public async Task<IEnumerable<ContributorDTO>> ListAsync()
   {
     // NOTE: This will fail if testing with EF InMemory provider
     var result = await _db.Database.SqlQuery<ContributorDTO>(
-      $"SELECT Id, Name, COALESCE(PhoneNumber_Number, '') AS PhoneNumber FROM Contributors") // don't fetch other big columns
-      //.Select(c => new ContributorDTO(c.Id, c.Name, c.PhoneNumber?.Number ?? ""))
+      $"SELECT Id, Name, PhoneNumber_Number AS PhoneNumber FROM Contributors") // don't fetch other big columns
+      //.Select(c => new ContributorDTO(c.Id, c.Name, c.PhoneNumber?.Number))
       .ToListAsync();
 
     return result;

src/Clean.Architecture.UseCases/Contributors/ContributorDTO.cs

@@ -1,2 +1,2 @@
 namespace Clean.Architecture.UseCases.Contributors;
-public record ContributorDTO(int Id, string Name, string PhoneNumber);
+public record ContributorDTO(int Id, string Name, string? PhoneNumber);

src/Clean.Architecture.Web/Clean.Architecture.Web.csproj

@@ -25,8 +25,4 @@
     <ProjectReference Include="..\Clean.Architecture.UseCases\Clean.Architecture.UseCases.csproj" />
   </ItemGroup>
 
-  <ItemGroup>
-    <Folder Include="wwwroot\" />
-  </ItemGroup>
-
 </Project>

src/Clean.Architecture.Web/Contributors/ContributorRecord.cs

@@ -1,3 +1,3 @@
 namespace Clean.Architecture.Web.ContributorEndpoints;
 
-public record ContributorRecord(int Id, string Name, string PhoneNumber);
+public record ContributorRecord(int Id, string Name, string? PhoneNumber);

tests/Clean.Architecture.UnitTests/UseCases/Contributors/CreateContributorHandlerHandle.cs

@@ -11,11 +11,11 @@ public class CreateContributorHandlerHandle
 {
   private readonly string _testName = "test name";
   private readonly IRepository<Contributor> _repository = Substitute.For<IRepository<Contributor>>();
-  private CreateContributorHandler _handler;
+  private readonly CreateContributorHandler _handler;
 
   public CreateContributorHandlerHandle()
   {
-      _handler = new CreateContributorHandler(_repository);
+    _handler = new CreateContributorHandler(_repository);
   }
 
   private Contributor CreateContributor()
@@ -30,6 +30,6 @@ public async Task ReturnsSuccessGivenValidName()
       .Returns(Task.FromResult(CreateContributor()));
     var result = await _handler.Handle(new CreateContributorCommand(_testName, null), CancellationToken.None);
 
-    result.IsSuccess.Should().BeTrue();    
+    result.IsSuccess.Should().BeTrue();
   }
 }