feat(staking): implement new staking design changes #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramarti
changed the title
Ramarti
force-pushed
the
staking-changes
branch
from
9303ab4
to
7713851
Compare
limengformal
requested review from
LeoHChen,
AndyBoWu,
jdubpark,
edisonz0718,
ezreal1997,
limengformal and
leeren
as code owners
Ramarti
force-pushed
the
staking-changes
branch
from
9621114
to
5b1b16e
Compare
* feat(evmstaking): unit tests feat(evmstaking): new staking events feat(evmstaking): unit tests for new staking events feat(evmstaking): unit tests for new staking events feat(evmstaking): rebase latest changes * feat(evmstaking): rebase latest changes
ezreal1997
force-pushed
the
staking-changes
branch
from
82925ed
to
6b0fe86
Compare
limengformal
approved these changes
Oct 15, 2024
ezreal1997
approved these changes
Oct 15, 2024
Binary uploaded successfully 🎉📦 Version Name: 0.12.0-unstable-f021bb9 |
| ) | ||
| external | ||
| payable | ||
| override |
There was a problem hiding this comment.
The override modifier might not be necessary here, since this contract doesn’t inherit from any other contract.
Comment on lines
+473
to
+477
| (uint256 stakeAmount, ) = roundedStakeAmount(msg.value); | ||
| if (stakeAmount < minStakeAmount) { | ||
| revert Errors.IPTokenStaking__StakeAmountUnderMin(); | ||
| } | ||
| emit Redelegate(delegatorUncmpPubkey, validatorUncmpSrcPubkey, validatorUncmpDstPubkey, delegationId, amount); |
There was a problem hiding this comment.
It would be add comments to explain why we don't need to refund remainder of roundedStakeAmount().
There was a problem hiding this comment.
If I understand correctly, the remainder will stay in the source validator. If that’s the case, we might explain how do we handle the remainder in the source validator, especially since it’s likely that the remainder will be less than the minStakeAmount. we might better add comments to explain why it is expected state/behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #184