feat(singularity): add singularity to mint and evmstaking module #202
+211
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xHansLee
requested review from
LeoHChen,
AndyBoWu,
jdubpark,
edisonz0718,
ezreal1997,
limengformal and
leeren
as code owners
0xHansLee
changed the title
0xHansLee
force-pushed
the
feat/add-singularity
branch
3 times, most recently
from
9a07d05
to
d28dc13
Compare
0xHansLee
changed the title
0xHansLee
force-pushed
the
feat/add-singularity
branch
from
d28dc13
to
9cd54f4
Compare
edisonz0718
reviewed
Oct 16, 2024
client/x/mint/types/params.go
Outdated
| @@ -26,7 +27,8 @@ func DefaultParams() Params { | |||
| return Params{ | |||
| MintDenom: sdk.DefaultBondDenom, | |||
| InflationsPerYear: math.LegacyNewDec(24625000000000000.000000000000000000), | |||
| BlocksPerYear: uint64(60 * 60 * 8766 / 5), // assuming 5 second block times | |||
| BlocksPerYear: uint64(60 * 60 * 8766 / 5), // assuming 5 seconds block times | |||
| SingularityHeight: 725760, // 42 days with assuming 5 seconds block time | |||
There was a problem hiding this comment.
Should we combine this with the other SingularityHeight in evmstaking to make it consistent?
There was a problem hiding this comment.
If possible, it would be better to combine into one, but I have no idea on combining this. Or one way for this is that we make a new keeper named singularity and import the keeper to both mint and evmstaking keeper. I think there is no need to make a new keeper for this, thus make like this. Do you have any better idea on this?
0xHansLee
force-pushed
the
feat/add-singularity
branch
4 times, most recently
from
a82de33
to
3af9f8c
Compare
0xHansLee
force-pushed
the
feat/add-singularity
branch
from
3af9f8c
to
db61453
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added singularity to mint and evmstaking module.
Until singularity height, no reward is minted and no validator set is updated.
BTW, there is one thing to discuss. What if user make requests for unstake greater than
MaxEntries? In CL side, when there are more unstake requests thanMaxEntries, it is processed as processing failure. However, in EL, unstake is processed normally, so I think we need to handle this. What do you think? I would like to discuss this because as the Singularity period gets longer, this possibility will increase.issue: none