Skip to content

Commit

Permalink
Adjust migrations effectively_installed methods to ensure correct run…
Browse files Browse the repository at this point in the history
…ning.
  • Loading branch information
rxu committed Apr 29, 2020
1 parent f119843 commit f4411b4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion migrations/v_1_2_8.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ class v_1_2_8 extends \phpbb\db\migration\migration
{
public function effectively_installed()
{
return isset($this->config['thanks_top_number']);
return $this->db_tools->sql_column_exists($this->table_prefix . 'thanks', 'topic_id') &&
$this->db_tools->sql_column_exists($this->table_prefix . 'thanks', 'forum_id') &&
$this->db_tools->sql_column_exists($this->table_prefix . 'thanks', 'thanks_time');
}

static public function depends_on()
Expand Down
2 changes: 1 addition & 1 deletion migrations/v_1_3_4.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class v_1_3_4 extends \phpbb\db\migration\migration
{
public function effectively_installed()
{
return isset($this->config['thanks_global_announce']);
return $this->db_tools->sql_index_exists($this->table_prefix . 'thanks', 'poster_id');
}

static public function depends_on()
Expand Down

0 comments on commit f4411b4

Please sign in to comment.