Add an option to expose hidden tabs #3495

piroor · Mar 19, 2024 · 7c000b0 · 7c000b0
1 parent 6cbe8ae
commit 7c000b0
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 4 deletions.
diff --git a/webextensions/common/Tab.js b/webextensions/common/Tab.js
@@ -2534,6 +2534,17 @@ Tab.getVisibleTabs = (windowId = null, options = {}) => { // visible, not-collap
   });
 };
 
+Tab.getHiddenTabs = (windowId = null, options = {}) => {
+  return TabsStore.queryAll({
+    windowId,
+    tabs:    TabsStore.getTabsMap(TabsStore.livingTabsInWindow, windowId),
+    living:  true,
+    ordered: true,
+    hidden:  true,
+    ...options
+  });
+};
+
 Tab.getPinnedTabs = (windowId = null, options = {}) => { // visible, pinned
   return TabsStore.queryAll({
     windowId,

diff --git a/webextensions/common/common.js b/webextensions/common/common.js
@@ -419,6 +419,7 @@ export const configs = new Configs({
   provressiveHighlightingStep: Number.MAX_SAFE_INTEGER,
   progressievHighlightingInterval: 100,
   outOfScreenTabsRenderingPages: 1,
+  renderHiddenTabs: false,
   generatedTabElementsPoolLifetimeMsec: 5 * 1000,
   undoMultipleTabsClose: true,
   allowDragNewTabButton: true,

diff --git a/webextensions/common/tabs-store.js b/webextensions/common/tabs-store.js
@@ -228,6 +228,9 @@ function matchedWithQuery(tab, query) {
        tab.hidden ||
        tabStates.has(Constants.kTAB_STATE_SHOWING)))
     return false;
+  if (query.hidden &&
+      !tab.hidden)
+    return false;
   if (query.controllable &&
       (tab.hidden ||
        tabStates.has(Constants.kTAB_STATE_SHOWING)))
@@ -489,7 +492,7 @@ export function updateIndexesForTab(tab) {
 
 export function updateVirtualScrollRenderabilityIndexForTab(tab) {
   if (tab.pinned ||
-      tab.hidden ||
+      (tab.hidden && !configs.renderHiddenTabs) ||
       tab.$TST.states.has(Constants.kTAB_STATE_COLLAPSED_DONE))
     removeVirtualScrollRenderableTab(tab);
   else

diff --git a/webextensions/sidebar/sidebar-tabs.js b/webextensions/sidebar/sidebar-tabs.js
@@ -442,6 +442,17 @@ configs.$addObserver(async changedKey => {
     case 'labelOverflowStyle':
       document.documentElement.setAttribute(Constants.kLABEL_OVERFLOW, configs.labelOverflowStyle);
       break;
+
+    case 'renderHiddenTabs': {
+      let hasNormalTab = false;
+      for (const tab of Tab.getHiddenTabs(TabsStore.getCurrentWindowId(), { iterator: true })) {
+        TabsStore.updateVirtualScrollRenderabilityIndexForTab(tab);
+        if (!tab.pinned)
+          hasNormalTab = true;
+      }
+      if (hasNormalTab)
+        onNormalTabsChanged.dispatch();
+    }; break;
   }
 });
 

diff --git a/webextensions/sidebar/styles/base.css b/webextensions/sidebar/styles/base.css
@@ -491,9 +491,7 @@ tab-item tab-favicon {
 }
 
 tab-item.hidden {
-  pointer-events: none;
-  position: fixed;
-  visibility: collapse;
+  opacity: 0.6;
 }
 
 :root.animation:not(.minimized) tab-item.animation-ready,