-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve command names, help output, and package layout #334
Draft
crhntr
wants to merge
20
commits into
main
Choose a base branch
from
feature/better-command-names--help-ouput--and-package-layout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Improve command names, help output, and package layout #334
crhntr
wants to merge
20
commits into
main
from
feature/better-command-names--help-ouput--and-package-layout
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
crhntr
changed the title
**[feature]** Improve command names, help output, and package layout
Improve command names, help output, and package layout
Sep 23, 2022
crhntr
force-pushed
the
feature/better-command-names--help-ouput--and-package-layout
branch
from
September 23, 2022 23:17
2806180
to
3362e3b
Compare
this is a strange command to have here. We create the pivnet release in an internal then come back to kiln to publish it. This makes more sense in ppet. It has been moved there.
…ign document https://3.basecamp.com/4957863/buckets/28333123/documents/5176885360 I made some deviations from the document. - i removed publish (tile). it is now in ppet (see previous commit) - added a line of "=" after the title - changed some of the whitespace/lines here is the document's suggestions: ----- kiln Kiln helps you manage, assemble and update OpsManager-compatible Tiles Component Team Commands: publish-release Makes Bosh Release available for inclusion in Tiles update-release Updates Lockfile to specified Bosh Release satisfying Kilnfile constraint Tile Commands: bake Assembles a Tile suitable for OpsManager consumption create-release-notes Collects GitHub Release notes for Tile Components publish Adds dates (release and EOGS) and license files to Tile Product on Pivnet validate Checks for common Kilnfile and Lockfile mistakes Component Commands: cache-releases Compiles uncompiled Bosh Releases, makes them available to PPE team for inclusion in Published Tiles fetch-releases Downloads Bosh Releases listed in Lockfile find-release-version Prints latest Bosh Release version satisfying Kilnfile constraint find-stemcell-version Prints latest Stemcell version on Pivnet satisfying Kilnfile constraint update-stemcell Updates Lockfile to latest Stemcell satisfying Kilnfile constraint Global Commands: help Prints this usage information version Prints Kiln version
I also made the tests table driven.
I also cleaned up the package API. I ran go mod tidy. I also ran gofumpt
crhntr
force-pushed
the
feature/better-command-names--help-ouput--and-package-layout
branch
from
October 13, 2022 17:30
18a4946
to
6c4cf73
Compare
This makes it easier for non-mac users to contribute.
the version constraint on stemcells does not limit the version...
this also fixes a bunch of awkward issues that came from default paths and default values being mixed up
Co-authored-by: Steve Taylor <[email protected]>
crhntr
force-pushed
the
feature/better-command-names--help-ouput--and-package-layout
branch
from
October 13, 2022 17:34
6c4cf73
to
6fef6aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of Kiln 1.0.