Be available as a Java Module #8
Conversation
| @@ -0,0 +1,10 @@ | |||
| /** Export our package so that it can be used by other modules. */ | |||
There was a problem hiding this comment.
If you're wondering, Mark Reinhold has weighed in and said the module names should be the core package name. This is not what Java did for their own modules, but whatever.
|
And if you're wondering about testing -- well, JUnit will not work from the command line unless you correctly configure the module settings. =) |
| <artifactId>java18</artifactId> | ||
| <version>1.0</version> | ||
| </signature> | ||
| <source>11</source> |
There was a problem hiding this comment.
Prefer release to source and target. It does the same thing, but also includes the functionality that the animal sniffer was giving you (makes sure you don't use an API not available in the release you're targeting).
| <version>1.0</version> | ||
| </signature> | ||
| <source>11</source> | ||
| <target>11</target> |
There was a problem hiding this comment.
I wouldn't be too quick to abandon the Java 8 users. We can try modulemaker maven plugin to generate the module-info, so that we don't need to upgrade our source to 11.
|
This is superseded by #9 |
In order to be accessible from programs using the JPMS, we needed to register imports/exports. That broke some of the build tooling and forced an upgrade to Java 11, so those changes are also here.