Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ FIX ] Fix test code for app samples #64

Merged
merged 12 commits into from
Aug 8, 2024
Merged

[ FIX ] Fix test code for app samples #64

merged 12 commits into from
Aug 8, 2024

Conversation

posaune0423
Copy link
Contributor

@posaune0423 posaune0423 commented Aug 7, 2024 •
edited
Loading

Overview

Mainly because Dojo implemented the concept of namespace, some part of test have been broken. so I fixed them.

Changes

  • add Github Actions for test contract so that we can recognize test is working or not
  • modify test according to the latest dojo code

@posaune0423 posaune0423 added the bug Something isn't working label Aug 7, 2024
@posaune0423 posaune0423 self-assigned this Aug 7, 2024
@posaune0423 posaune0423 changed the title [ FIX ] test code for app samples [ FIX ] Fix test code for app samples Aug 7, 2024
@posaune0423 posaune0423 marked this pull request as ready for review August 7, 2024 20:06
@posaune0423 posaune0423 requested a review from thiscaspar August 7, 2024 20:45
@thiscaspar thiscaspar merged commit 12b72b6 into main Aug 8, 2024
2 checks passed
@thiscaspar thiscaspar deleted the update/test-code branch August 8, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiscaspar thiscaspar Awaiting requested review from thiscaspar

Assignees

@posaune0423 posaune0423

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@posaune0423 @thiscaspar