Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ IFX ] Modify for deploy to starknet #70

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

posaune0423
Copy link
Contributor

Changes

  • Add docs about deployment
  • remove print cuz they seems to be not allowed in Starknet public network (from warning)
  • modify config

@posaune0423 posaune0423 added documentation Improvements or additions to documentation contracts labels Sep 12, 2024
@posaune0423 posaune0423 self-assigned this Sep 12, 2024
@thiscaspar
Copy link
Member

it would be nice to have a post-compile (or pre-deploy) script using sed (or something) that strips all print! and println! lines automatically.

@posaune0423 posaune0423 force-pushed the fix/for-starknet-deployment branch from af1f99a to 834843a Compare September 16, 2024 21:54
@posaune0423
Copy link
Contributor Author

@thiscaspar

it would be nice to have a post-compile (or pre-deploy) script using sed (or something) that strips all print! and println! lines automatically.

Thank you for reviewing! If you don't like removing the print code for debug, how about just commenting out them by default. Because it's not common to leave debug code in production contract code?

@posaune0423 posaune0423 marked this pull request as ready for review September 16, 2024 22:15
@thiscaspar
Copy link
Member

sure, you're right.. lets not keep print's around in prod code.

@thiscaspar thiscaspar merged commit e6b2aba into main Sep 16, 2024
2 checks passed
@thiscaspar thiscaspar deleted the fix/for-starknet-deployment branch September 16, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants